[webkit-reviews] review granted: [Bug 210180] Introduce a RealtimeMediaSource observer dedicated to receiving audio samples : [Attachment 395792] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 210180: Introduce a RealtimeMediaSource observer dedicated to receiving
audio samples
https://bugs.webkit.org/show_bug.cgi?id=210180

Attachment 395792: Patch

https://bugs.webkit.org/attachment.cgi?id=395792&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 395792
  --> https://bugs.webkit.org/attachment.cgi?id=395792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395792&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.h:41
> +typedef
std::unique_ptr<MediaRecorderPrivate>(*creatorFunction)(MediaStreamPrivate&);

Nit: could change to "using"

> Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:126
> +    if (!m_shouldPlay || m_muted || streamTrack().muted() ||
streamTrack().ended() || !streamTrack().enabled()) {
> +	   stopRenderer();
>	   return;

Might as well stop the renderer when the volume is set to 0 too.

> Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h:125
> +    void audioSamplesAvailable(const MediaTime&, const PlatformAudioData&,
const AudioStreamDescription&, size_t) override { };

As we discussed, it may be possible to remove this.