[webkit-reviews] review granted: [Bug 210132] [CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner : [Attachment 395715] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 210132: [CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=210132

Attachment 395715: Patch

https://bugs.webkit.org/attachment.cgi?id=395715&action=review




--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 395715
  --> https://bugs.webkit.org/attachment.cgi?id=395715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395715&action=review

Simplifications are always welcome :]

> Tools/WebKitTestRunner/CMakeLists.txt:34
> +    ${CMAKE_BINARY_DIR}

Just wondering… it seems quite common to add ${CMAKE_BINARY_DIR} as
one of the include directories, so maybe it would make sense to always
add it in the _WEBKIT_TARGET() macro. WDYT?