[webkit-reviews] review granted: [Bug 210067] [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in TestWebKitAPI : [Attachment 395645] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 210067: [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings
in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=210067

Attachment 395645: Patch

https://bugs.webkit.org/attachment.cgi?id=395645&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 395645
  --> https://bugs.webkit.org/attachment.cgi?id=395645
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395645&action=review

> Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp:774
> -    maxIntRect.shiftMaxXEdgeTo(INT_MAX);
> -    maxIntRect.shiftMaxYEdgeTo(INT_MAX);
> +    maxIntRect.shiftMaxXEdgeTo(0);
> +    maxIntRect.shiftMaxYEdgeTo(0);

Seems like we should use some positive number larger than 0 but smaller than
INT_MAX instead.