[webkit-reviews] review granted: [Bug 210126] [JSC] ScopedArgumentsTable should handle OOM in tolerant manner : [Attachment 395690] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210126: [JSC] ScopedArgumentsTable should handle OOM in tolerant manner
https://bugs.webkit.org/show_bug.cgi?id=210126

Attachment 395690: Patch

https://bugs.webkit.org/attachment.cgi?id=395690&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 395690
  --> https://bugs.webkit.org/attachment.cgi?id=395690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395690&action=review

r=me

> Source/JavaScriptCore/runtime/ScopedArguments.cpp:146
> +    auto scope = DECLARE_THROW_SCOPE(vm);

You’re adding a ThrowScope.  Make sure to run JSC stress tests with a debug
build (use --force-opt=O3 to run faster) to make sure there’s no new missing
exception check failures.