[webkit-reviews] review canceled: [Bug 210094] VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash` : [Attachment 395651] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 7 08:27:52 PDT 2020


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 210094: VisitedLinkStore.messages.in and
VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of
`linkHash`
https://bugs.webkit.org/show_bug.cgi?id=210094

Attachment 395651: Patch v1

https://bugs.webkit.org/attachment.cgi?id=395651&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 395651
  --> https://bugs.webkit.org/attachment.cgi?id=395651
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review

>> Source/WebKit/Scripts/webkit/messages.py:618
>> +	    'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'],
> 
> Why is this needed? Seems like this would be the default.

Oops, it's not.  I'm new to this code.	Thanks!


More information about the webkit-reviews mailing list