[webkit-reviews] review granted: [Bug 207671] Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate : [Attachment 390585] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 207671: Add release assert for valid registration data in
ServiceWorkerRegistration::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=207671

Attachment 390585: Patch

https://bugs.webkit.org/attachment.cgi?id=390585&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 390585
  --> https://bugs.webkit.org/attachment.cgi?id=390585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390585&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:51
> +    RELEASE_ASSERT(!data.scopeURL.isNull());

Why not use URL::isValid() instead?