[webkit-reviews] review granted: [Bug 210059] [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree : [Attachment 395625] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 210059: [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=210059

Attachment 395625: Patch

https://bugs.webkit.org/attachment.cgi?id=395625&action=review




--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 395625
  --> https://bugs.webkit.org/attachment.cgi?id=395625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395625&action=review

> Tools/DumpRenderTree/CMakeLists.txt:45
> +    ${PAL_FRAMEWORK_HEADERS_DIR}

Do you need to add PAL_FRAMEWORK_HEADERS_DIR? Why don't you use WebKit::PAL?