[webkit-reviews] review granted: [Bug 209685] REGRESSION: 4 TestWebKitAPI.DragAndDropTests.DataTransferSetData tests failing on iOS : [Attachment 395610] Fix typo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 13:38:23 PDT 2020


Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 209685: REGRESSION: 4 TestWebKitAPI.DragAndDropTests.DataTransferSetData
tests failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=209685

Attachment 395610: Fix typo

https://bugs.webkit.org/attachment.cgi?id=395610&action=review




--- Comment #12 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 395610
  --> https://bugs.webkit.org/attachment.cgi?id=395610
Fix typo

View in context: https://bugs.webkit.org/attachment.cgi?id=395610&action=review

> Source/WebCore/editing/Editor.cpp:432
>  

This seems like just a rework of the replaced code? Is there a reason we don't
need to explicitly clear the new pasteboard anymore?

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:859
>      _stagedRegistrationInfoLists = lists;

Was this the only logging that was left? I thought there was a lot more?


More information about the webkit-reviews mailing list