[webkit-reviews] review granted: [Bug 210042] Make ScrollableArea TextStream-loggable : [Attachment 395600] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 12:25:08 PDT 2020


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 210042: Make ScrollableArea TextStream-loggable
https://bugs.webkit.org/show_bug.cgi?id=210042

Attachment 395600: Patch

https://bugs.webkit.org/attachment.cgi?id=395600&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 395600
  --> https://bugs.webkit.org/attachment.cgi?id=395600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395600&action=review

> Source/WebCore/rendering/RenderListBox.cpp:916
> +String RenderListBox::debugDescription() const
> +{
> +    return RenderObject::debugDescription();
> +}

What is this about? Why not just omit this override entirely?


More information about the webkit-reviews mailing list