[webkit-reviews] review granted: [Bug 210049] ProcessAssertion should use ASCIILiteral for its reason : [Attachment 395568] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 6 10:17:19 PDT 2020
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 210049: ProcessAssertion should use ASCIILiteral for its reason
https://bugs.webkit.org/show_bug.cgi?id=210049
Attachment 395568: Patch
https://bugs.webkit.org/attachment.cgi?id=395568&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 395568
--> https://bugs.webkit.org/attachment.cgi?id=395568
Patch
This seems silly to me. The API takes an NSString. Using stringWithCString
and NSASCIIStringEncoding doesn't improve anything. This is just documenting
that all the strings we use happen to be ASCII right now.
More information about the webkit-reviews
mailing list