[webkit-reviews] review granted: [Bug 209923] [WebAuthn] Cancel WebAuthn requests after users cancelling LocalAuthentication prompts : [Attachment 395295] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 209923: [WebAuthn] Cancel WebAuthn requests after users cancelling
LocalAuthentication prompts
https://bugs.webkit.org/show_bug.cgi?id=209923

Attachment 395295: Patch

https://bugs.webkit.org/attachment.cgi?id=395295&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 395295
  --> https://bugs.webkit.org/attachment.cgi?id=395295
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395295&action=review

Very nice! r=me (but please include my suggested changes).

> Source/WebCore/ChangeLog:3
> +	   [WebAuthn] Cancel WebAuthn requests after users cancelling
LocalAuthentication prompts

[WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication
prompts

> Source/WebKit/ChangeLog:10
> +	   users cancellation on LocalAuthentication UI as it were on UI
clients' WebAuthn UI.

"Here, we should treat user cancellation of the LocalAuthentication UI as if it
were being done on the UI Client's WebAuthn UI."

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:-63
> -

Please remove this whitespace change, which will remove this entire file from
the patch.