[webkit-reviews] review granted: [Bug 210037] JSC shell shouldn't treat NUL as a terminator when printing a JS string : [Attachment 395533] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 210037: JSC shell shouldn't treat NUL as a terminator when printing a JS
string
https://bugs.webkit.org/show_bug.cgi?id=210037

Attachment 395533: Patch

https://bugs.webkit.org/attachment.cgi?id=395533&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 395533
  --> https://bugs.webkit.org/attachment.cgi?id=395533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395533&action=review

> Source/JavaScriptCore/jsc.cpp:1293
> +    fprintf(stderr, "--> ");

fputs?

> Source/JavaScriptCore/jsc.cpp:1295
> +    fprintf(stderr, "\n");

putc?

> Source/JavaScriptCore/jsc.cpp:2803
> +	       printf("Exception: ");

puts?

> Source/JavaScriptCore/jsc.cpp:2808
> +	   printf("\n");

putchar?

> JSTests/ChangeLog:11
> +	   Update baseline, but ensure that \0 isn't printed to file, lest the
file be treated as binary.

For testing purposes I often like the idea of replacing a NUL with something
like "<NUL>" rather than just deleting it. Seems more likely to help us catch
bugs and unlikely to cause confusion.