[webkit-reviews] review granted: [Bug 204979] The value of [AVPlayerViewController isPictureInPicturePossible] is NO in the first attempt to enter PiP : [Attachment 395529] A follow-up patch to fix mistakes on #if HAVE(HAVE_AVOBSERVATIONCONTROLLER)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 5 15:00:24 PDT 2020


Darin Adler <darin at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 204979: The value of [AVPlayerViewController isPictureInPicturePossible] is
NO in the first attempt to enter PiP
https://bugs.webkit.org/show_bug.cgi?id=204979

Attachment 395529: A follow-up patch to fix mistakes on #if
HAVE(HAVE_AVOBSERVATIONCONTROLLER)

https://bugs.webkit.org/attachment.cgi?id=395529&action=review




--- Comment #25 from Darin Adler <darin at apple.com> ---
Comment on attachment 395529
  --> https://bugs.webkit.org/attachment.cgi?id=395529
A follow-up patch to fix mistakes on #if HAVE(HAVE_AVOBSERVATIONCONTROLLER)

Any way to add a test for this? I caught it by code inspection, but that’s not
a reliable way to check these things.


More information about the webkit-reviews mailing list