[webkit-reviews] review granted: [Bug 210035] Make RenderObject TextStream-loggable : [Attachment 395522] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 210035: Make RenderObject TextStream-loggable
https://bugs.webkit.org/show_bug.cgi?id=210035

Attachment 395522: Patch

https://bugs.webkit.org/attachment.cgi?id=395522&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 395522
  --> https://bugs.webkit.org/attachment.cgi?id=395522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395522&action=review

> Source/WebCore/rendering/RenderObject.cpp:1918
> +    builder.append(' ');

this will generate trailing whitespace for anonymous renderer (not really an
issue though).

> Source/WebCore/rendering/RenderObject.h:786
> +    virtual String debugDescription() const;

why virtual?