[webkit-reviews] review requested: [Bug 209998] Web Inspector: Debugger: treat comma sub-expressions as separate statements : [Attachment 395495] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 5 01:59:26 PDT 2020
Devin Rousso <drousso at apple.com> has asked for review:
Bug 209998: Web Inspector: Debugger: treat comma sub-expressions as separate
statements
https://bugs.webkit.org/show_bug.cgi?id=209998
Attachment 395495: Patch
https://bugs.webkit.org/attachment.cgi?id=395495&action=review
--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Created attachment 395495
--> https://bugs.webkit.org/attachment.cgi?id=395495&action=review
Patch
Turns out, the only reason I needed to have `m_lastExecutedPosition` was
because I was unnecessarily `emitDebugHook` before the first `CommaNode`, which
really should already be handled by the container `StatementNode`.In addition
to considering each `CommaNode` as a pause location, we should also consider
them as a possible breakpoint location.
More information about the webkit-reviews
mailing list