[webkit-reviews] review requested: [Bug 210014] Web Inspector: replace `featureGuard` and `availability` with a combined `condition` that accepts any macro : [Attachment 395472] [Patch] WIP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 4 19:48:46 PDT 2020


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 210014: Web Inspector: replace `featureGuard` and `availability` with a
combined `condition` that accepts any macro
https://bugs.webkit.org/show_bug.cgi?id=210014

Attachment 395472: [Patch] WIP

https://bugs.webkit.org/attachment.cgi?id=395472&action=review




--- Comment #1 from Devin Rousso <drousso at apple.com> ---
Created attachment 395472

  --> https://bugs.webkit.org/attachment.cgi?id=395472&action=review

[Patch] WIP

Because we use macros in 'InspectorBackendCommands.js' too, we need to
preprocess it.	I've managed to get it working with `make`, but it also isn't
nicely formatted (lots of extra newlines).  I need to get CMake working too.


More information about the webkit-reviews mailing list