[webkit-reviews] review granted: [Bug 209984] [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard : [Attachment 395409] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 4 16:40:15 PDT 2020
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 209984: [iOS] Simplify ProcessAssertion class in preparation for switch to
RunningBoard
https://bugs.webkit.org/show_bug.cgi?id=209984
Attachment 395409: Patch
https://bugs.webkit.org/attachment.cgi?id=395409&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 395409
--> https://bugs.webkit.org/attachment.cgi?id=395409
Patch
If reasons are always C++ literals, why store them in WTF::String? We could
just store as const char* or maybe even as WTF::ASCIILiteral.
More information about the webkit-reviews
mailing list