[webkit-reviews] review granted: [Bug 210007] Remove LockHistory parameter from loadWithNavigationAction : [Attachment 395456] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 210007: Remove LockHistory parameter from loadWithNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=210007

Attachment 395456: Patch

https://bugs.webkit.org/attachment.cgi?id=395456&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 395456
  --> https://bugs.webkit.org/attachment.cgi?id=395456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review

> Source/WebCore/loader/FrameLoader.cpp:1424
> -    loadWithNavigationAction(request, WTFMove(action), lockHistory,
newLoadType, WTFMove(formState), allowNavigationToInvalidURL,
frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType,
protectedFrame = makeRef(m_frame), completionHandler =
completionHandlerCaller.release()] () mutable {
> +    loadWithNavigationAction(request, WTFMove(action), newLoadType,
WTFMove(formState), allowNavigationToInvalidURL,
frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType,
protectedFrame = makeRef(m_frame), completionHandler =
completionHandlerCaller.release()] () mutable {

How did you determine that it’s not necessary to call setLockHistory on the
action here, the way you did in FrameLoader::loadWithNavigationAction?