[webkit-reviews] review granted: [Bug 205185] Add feature status for CSS Grid Level 2 : [Attachment 385626] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 4 16:15:02 PDT 2020


Daniel Bates <dbates at webkit.org> has granted esisk at apple.com's request for
review:
Bug 205185: Add feature status for CSS Grid Level 2
https://bugs.webkit.org/show_bug.cgi?id=205185

Attachment 385626: Patch

https://bugs.webkit.org/attachment.cgi?id=385626&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 385626
  --> https://bugs.webkit.org/attachment.cgi?id=385626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385626&action=review

Patch looks good. I'll consider grid 2!

> Source/WebCore/features.json:121
> +	       "enabled-by-default": false

OK as-is. The optimal solution would just omit this line because there is no
feature flag for this work.


More information about the webkit-reviews mailing list