[webkit-reviews] review granted: [Bug 209888] Track editable elements on screen : [Attachment 395419] Patch and tests

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 209888: Track editable elements on screen
https://bugs.webkit.org/show_bug.cgi?id=209888

Attachment 395419: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=395419&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 395419
  --> https://bugs.webkit.org/attachment.cgi?id=395419
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=395419&action=review

> Source/WebCore/dom/Document.h:1249
>  #if PLATFORM(IOS_FAMILY)

This should be wrapped in a TOUCH_ACTION #ifdef

> Source/WebCore/dom/Document.h:1254
> +    bool mayHaveEditableElements() const { return m_mayHaveEditableElements;
}
> +    void setMayHaveEditableElements() { m_mayHaveEditableElements = true; }

And this should be wrapped in an EDITABLE_REGIONS #ifdef

> Source/WebCore/rendering/RenderLayerBacking.cpp:1626
>  #if PLATFORM(IOS_FAMILY)
>      hasTouchActionElements =
renderer().document().mayHaveElementsWithNonAutoTouchAction();
> +    hasEditableElements = renderer().document().mayHaveEditableElements();
>  #endif

Would be nice not to use a platform #ifdef.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2093
> +- (BOOL)_mightContainEditableElementsInRect:(CGRect)rect

_mayContain?

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:84
> +bool mightContainEditableElementsInRect(UIView *rootView, const
WebCore::FloatRect&);

mayContain

> Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:122
> +    // Editable region
> +
> +    virtual bool mightContainEditableElementsInRect(unsigned, unsigned,
unsigned, unsigned) { notImplemented(); return false; }

Blank line. mayContain?