[webkit-reviews] review granted: [Bug 209980] REGRESSION (r8412): Use RetainPtr<> for NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:] : [Attachment 395400] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 3 12:18:34 PDT 2020


Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 209980: REGRESSION (r8412): Use RetainPtr<> for NSMutableAttributedString
in -[WebAccessibilityObjectWrapper
doAXAttributedStringForTextMarkerRange:spellCheck:]
https://bugs.webkit.org/show_bug.cgi?id=209980

Attachment 395400: Patch v1

https://bugs.webkit.org/attachment.cgi?id=395400&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 395400
  --> https://bugs.webkit.org/attachment.cgi?id=395400
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=395400&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1258
> +	   RetainPtr<NSMutableAttributedString> attrString =
adoptNS([[NSMutableAttributedString alloc] init]);

Could just write:

    auto attrString = ...


More information about the webkit-reviews mailing list