[webkit-reviews] review granted: [Bug 209973] Remove _setIsNavigatingToAppBoundDomain testing SPI : [Attachment 395390] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted
katherine_cheney at apple.com's request for review:
Bug 209973: Remove _setIsNavigatingToAppBoundDomain testing SPI
https://bugs.webkit.org/show_bug.cgi?id=209973

Attachment 395390: Patch

https://bugs.webkit.org/attachment.cgi?id=395390&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 395390
  --> https://bugs.webkit.org/attachment.cgi?id=395390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395390&action=review

r=me assuming EWS passes.  Consider renaming `request2` as well.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:239
> +    NSURLRequest *request2 = [NSURLRequest requestWithURL:[[NSBundle
mainBundle] URLForResource:@"in-app-browser-privacy-local-file"
withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];

Nit: `request2` isn't a great variable name.  Better to reuse `request` from
above (since it's no longer used), or change it to something like
`localFileRequest` or `fileRequest`.