[webkit-reviews] review granted: [Bug 209940] Web Inspector: increase the auto-inspect debugger timeout delay to account for slower networks/devices : [Attachment 395322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 19:17:03 PDT 2020


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 209940: Web Inspector: increase the auto-inspect debugger timeout delay to
account for slower networks/devices
https://bugs.webkit.org/show_bug.cgi?id=209940

Attachment 395322: Patch

https://bugs.webkit.org/attachment.cgi?id=395322&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 395322
  --> https://bugs.webkit.org/attachment.cgi?id=395322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395322&action=review

r=me

> Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:160
> +	   dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 10 * NSEC_PER_SEC),
dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{

Would still be good to pull this out as a constant so its easier to read.


More information about the webkit-reviews mailing list