[webkit-reviews] review granted: [Bug 209919] Don't call -[AVCapture startRunning] when interruption ends : [Attachment 395288] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 209919: Don't call -[AVCapture startRunning] when interruption ends
https://bugs.webkit.org/show_bug.cgi?id=209919

Attachment 395288: Patch

https://bugs.webkit.org/attachment.cgi?id=395288&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 395288
  --> https://bugs.webkit.org/attachment.cgi?id=395288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395288&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:623
>      m_interruption = InterruptionReason::None;

Maybe we could switch m_interruption to "boolean m_interrupted"?

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:698
> +    if (!willChange && m_callback->loggerPtr() &&
m_callback->logger().willLog(m_callback->logChannel(), WTFLogLevel::Always)) {

Why !willChange?
I would think could write it as if (willChange) or maybe if(isChanging).

Should we return early if wilChange is true?