[webkit-reviews] review granted: [Bug 209909] Avoid null deref after inserting a text field with a list attribute : [Attachment 395276] Add description to test case

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 209909: Avoid null deref after inserting a text field with a list attribute
https://bugs.webkit.org/show_bug.cgi?id=209909

Attachment 395276: Add description to test case

https://bugs.webkit.org/attachment.cgi?id=395276&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 395276
  --> https://bugs.webkit.org/attachment.cgi?id=395276
Add description to test case

View in context: https://bugs.webkit.org/attachment.cgi?id=395276&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1558
> +#if ENABLE(DATALIST_ELEMENT)
> +    if (isConnected() && m_hasNonEmptyList)
> +	   dataListMayHaveChanged();
> +#endif

By this time, author scripts may have ran so it's possible that some code that
would have accessed things like computed style and bounding rect that rely on
the updated style.
I guess that's okay because this only affects painting?