[webkit-reviews] review granted: [Bug 204283] Add initial support for WebRTC HEVC : [Attachment 395261] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 10:12:57 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 204283: Add initial support for WebRTC HEVC
https://bugs.webkit.org/show_bug.cgi?id=204283

Attachment 395261: Patch

https://bugs.webkit.org/attachment.cgi?id=395261&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 395261
  --> https://bugs.webkit.org/attachment.cgi?id=395261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395261&action=review

> LayoutTests/webrtc/h265.html:58
> +		   setTimeout(() => reject("Test timed out"), 2000);

Will 2 seconds long be long enough on a heavily loaded machine?

> LayoutTests/webrtc/h265.html:74
> +	       setTimeout(() => reject("Test timed out"), 2000);

Ditto.


More information about the webkit-reviews mailing list