[webkit-reviews] review granted: [Bug 209903] Video previews on shutterstock.com don't play when tapped on iPadOS : [Attachment 395264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 07:57:31 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 209903: Video previews on shutterstock.com don't play when tapped on iPadOS
https://bugs.webkit.org/show_bug.cgi?id=209903

Attachment 395264: Patch

https://bugs.webkit.org/attachment.cgi?id=395264&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 395264
  --> https://bugs.webkit.org/attachment.cgi?id=395264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395264&action=review

> Source/WebCore/loader/DocumentLoader.h:138
> +    Allow,
> +    Deny,

Nit - sounds a bit weird for a `CanPrevent~` enum to have values of Allow and
Deny. Maybe just Default, No, and Yes?


More information about the webkit-reviews mailing list