[webkit-reviews] review granted: [Bug 209875] Remove unused media controls code : [Attachment 395216] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 209875: Remove unused media controls code
https://bugs.webkit.org/show_bug.cgi?id=209875

Attachment 395216: Patch

https://bugs.webkit.org/attachment.cgi?id=395216&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 395216
  --> https://bugs.webkit.org/attachment.cgi?id=395216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395216&action=review

Patch looks good. Check Windows.

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:163
> +	   return m_textTrackContainer.get();

Ok as is. No change needed. Looks like line is indented.

> Source/WebCore/html/HTMLMediaElement.cpp:4300
> +    if (m_creatingControls)

This is ok as-is. No change needed. Is this change concealing a bug revealed by
this removal? If so, why is it ok to make this change? If not, proceed.

> Source/WebCore/html/HTMLMediaElement.cpp:4303
>      m_creatingControls = true;

Ok as-is. No change needed. In the future the optimal solution is to use
SETforScope() class for this ivar toggling.