[webkit-reviews] review granted: [Bug 209883] Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType : [Attachment 395210] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 209883: Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=209883

Attachment 395210: Patch

https://bugs.webkit.org/attachment.cgi?id=395210&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 395210
  --> https://bugs.webkit.org/attachment.cgi?id=395210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395210&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:814
> +#if PLATFORM(IOS_FAMILY)
> +    return true;
> +#else
> +    return false;
> +#endif

If this is just a platform conditional, do we really need to use the client
design pattern? Or perhaps there is some way this is likely to be dynamic in
the future that we are preparing for?

The client system is mildly elaborate and is worthwhile mainly when we want a
true separation of concerns between WebCore and WebKit layers, not just for
platform differences.