[webkit-reviews] review granted: [Bug 209873] Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation : [Attachment 395196] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 209873: Regression(r257963) didFailProvisionalNavigation delegate no longer
gets called when cancelling a cross-site provisional navigation
https://bugs.webkit.org/show_bug.cgi?id=209873

Attachment 395196: Patch

https://bugs.webkit.org/attachment.cgi?id=395196&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 395196
  --> https://bugs.webkit.org/attachment.cgi?id=395196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395196&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:136
> +    FrameInfoData frameInfo {

FrameInfoData is supposed to only be created in the web process because
otherwise it is out of date and the frame could've navigated underneath us.  I
don't see another way to do this though.