[webkit-reviews] review granted: [Bug 209849] CanvasRenderingContext2D.drawImage should ignore the EXIF orientation if the image-orientation is none : [Attachment 395189] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 209849: CanvasRenderingContext2D.drawImage should ignore the EXIF
orientation if the image-orientation is none
https://bugs.webkit.org/show_bug.cgi?id=209849

Attachment 395189: Patch

https://bugs.webkit.org/attachment.cgi?id=395189&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 395189
  --> https://bugs.webkit.org/attachment.cgi?id=395189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395189&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1467
> +    ImageOrientation imageOrientation = ImageOrientation::FromImage;

Seems like in the context of this function we don’t have to keep repeating the
word image so much. I would have written:

    auto orientation = ImageOrientation::FromImage;