[webkit-reviews] review requested: [Bug 202374] Web Inspector: JS Formatter: unexpected newlines added inside template string expression : [Attachment 379859] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 30 16:54:33 PDT 2019
Devin Rousso <drousso at apple.com> has asked for review:
Bug 202374: Web Inspector: JS Formatter: unexpected newlines added inside
template string expression
https://bugs.webkit.org/show_bug.cgi?id=202374
Attachment 379859: Patch
https://bugs.webkit.org/attachment.cgi?id=379859&action=review
--- Comment #1 from Devin Rousso <drousso at apple.com> ---
Created attachment 379859
--> https://bugs.webkit.org/attachment.cgi?id=379859&action=review
Patch
This feels a bit hacky, but considering how basically anything can be put
inside a template literal, it needs a more widespread solution. I'd imagine
that most uses of template literals are usually simple (e.g. print a variable,
call a function, or do some basic math), so effectively preventing all
non-forced newlines seems fine to me.
More information about the webkit-reviews
mailing list