[webkit-reviews] review granted: [Bug 202356] Add some assertions to convertUTF8ToUTF16(). : [Attachment 379820] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 29 16:30:58 PDT 2019


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 202356: Add some assertions to convertUTF8ToUTF16().
https://bugs.webkit.org/show_bug.cgi?id=202356

Attachment 379820: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=379820&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379820
  --> https://bugs.webkit.org/attachment.cgi?id=379820
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=379820&action=review

> Source/WTF/wtf/unicode/UTF8Conversion.cpp:95
> +    RELEASE_ASSERT(targetEnd - target <= std::numeric_limits<int>::max());

why does the code require this?


More information about the webkit-reviews mailing list