[webkit-reviews] review granted: [Bug 202326] [IDL] Support record<DOMString, *Callback> in bindings : [Attachment 379755] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 28 16:32:19 PDT 2019


Sam Weinig <sam at webkit.org> has granted Wenson Hsieh <wenson_hsieh at apple.com>'s
request for review:
Bug 202326: [IDL] Support record<DOMString, *Callback> in bindings
https://bugs.webkit.org/show_bug.cgi?id=202326

Attachment 379755: Patch

https://bugs.webkit.org/attachment.cgi?id=379755&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 379755
  --> https://bugs.webkit.org/attachment.cgi?id=379755
Patch

Looks good. Out of curiosity, do we handle *Callback (or any other
JSDOMGlobalObject requiring type) in other aggregate and / or parametrized
types (e.g. sequence<>, Promise<>, FrozenArray<>, union, etc.)


More information about the webkit-reviews mailing list