[webkit-reviews] review granted: [Bug 202351] [LFC][IFC] Move horizontal alignment to Line : [Attachment 379795] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 202351: [LFC][IFC] Move horizontal alignment to Line
https://bugs.webkit.org/show_bug.cgi?id=202351

Attachment 379795: Patch

https://bugs.webkit.org/attachment.cgi?id=379795&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 379795
  --> https://bugs.webkit.org/attachment.cgi?id=379795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379795&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:60
> +Line::Line(const InlineFormattingContext& inlineFormattingContext, const
InitialConstraints& initialConstraints, Optional<TextAlignMode>
horizontalAlignment,  SkipAlignment skipAlignment)

Double space before SkipAlignment

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:136
> +	   verticalAlignContent();
> +	   horizontalAlignContent();

alignContentVerticall() would read better, or just alignVertically(). But maybe
there is some naming pattern here to match the property name?