[webkit-reviews] review granted: [Bug 202315] Move legacy custom protocol registration from process pool to NetworkProcessProxy : [Attachment 379735] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 27 13:13:29 PDT 2019
Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202315: Move legacy custom protocol registration from process pool to
NetworkProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=202315
Attachment 379735: Patch
https://bugs.webkit.org/attachment.cgi?id=379735&action=review
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 379735
--> https://bugs.webkit.org/attachment.cgi?id=379735
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=379735&action=review
> Source/WebKit/ChangeLog:15
> +
words
> Source/WebKit/UIProcess/WebProcessPool.cpp:1527
> +
processPool->ensureNetworkProcess().unregisterSchemeForLegacyCustomProtocol(url
Scheme);
Why is the structure of these different? Ensure to unregister but not register?
More information about the webkit-reviews
mailing list