[webkit-reviews] review granted: [Bug 202324] OSR exit shouldn't bother updating get_by_id array profiles that have changed modes : [Attachment 379744] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 202324: OSR exit shouldn't bother updating get_by_id array profiles that
have changed modes
https://bugs.webkit.org/show_bug.cgi?id=202324

Attachment 379744: Patch

https://bugs.webkit.org/attachment.cgi?id=379744&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 379744
  --> https://bugs.webkit.org/attachment.cgi?id=379744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379744&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:523
> +	       bool doProfile = instruction->opcodeID() != op_get_by_id ||
instruction->as<OpGetById>().metadata(profiledCodeBlock).m_modeMetadata.mode ==
GetByIdMode::ArrayLength;

You can use `!instruction->is<OpGetById>()`.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:1176
> +		   if (instruction->opcodeID() == op_get_by_id) {

Ditto. You can use `instruction->is<OpGetById>()`.