[webkit-reviews] review granted: [Bug 201642] [GTK][WPE] Add WebKitWebView:page-id property : [Attachment 379625] Rebased patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 201642: [GTK][WPE] Add WebKitWebView:page-id property
https://bugs.webkit.org/show_bug.cgi?id=201642

Attachment 379625: Rebased patch

https://bugs.webkit.org/attachment.cgi?id=379625&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 379625
  --> https://bugs.webkit.org/attachment.cgi?id=379625
Rebased patch

Exposing the messaging APIs sounds like a good idea to me, since using page IDs
feels fragile now that we have PSON.

Still, removing page IDs completely from the API is not possible unless we
totally give up on any pretense of backwards-compatibility and bump the API
version. Deprecating these APIs and making them return, say, 0 would break too
many apps. Having changing page IDs is risky enough as it is.

Anyway, hopefully we never have to do that. Even if we somebody have to, adding
it as a property until then has no downsides. So r=me, except owner approval is
required for PageClient.h and WebPageProxy.cpp.