[webkit-reviews] review granted: [Bug 202270] IDBRequest should not prevent a page from entering the back/forward cache : [Attachment 379644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 27 07:48:52 PDT 2019


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202270: IDBRequest should not prevent a page from entering the back/forward
cache
https://bugs.webkit.org/show_bug.cgi?id=202270

Attachment 379644: Patch

https://bugs.webkit.org/attachment.cgi?id=379644&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 379644
  --> https://bugs.webkit.org/attachment.cgi?id=379644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265
> +    return true;

This change also affects IDBOpenDBRequest.
I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events
are enqueued).
It might be good to double check this though.


More information about the webkit-reviews mailing list