[webkit-reviews] review granted: [Bug 202201] [Nicosia] Implement frame scrolling functionality : [Attachment 379545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 27 01:29:19 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 202201: [Nicosia] Implement frame scrolling functionality
https://bugs.webkit.org/show_bug.cgi?id=202201

Attachment 379545: Patch

https://bugs.webkit.org/attachment.cgi?id=379545&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 379545
  --> https://bugs.webkit.org/attachment.cgi?id=379545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379545&action=review

>
Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cp
p:161
> +		   [&position](Nicosia::CompositionLayer::LayerState& state)

why not position = WTFMove(position)? it's an rvalue ref

>
Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cp
p:163
> +		       state.position = position;

and WTFMove(position) here too.

>
Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cp
p:183
> +	   applyLayerPosition(*m_rootContentsLayer, rootContentsPosition);
> +	   if (m_contentShadowLayer)
> +	       applyLayerPosition(*m_contentShadowLayer, rootContentsPosition);

hmm position can't be moved, so maybe the lambda should receive a ref instead
of an rvalue ref.


More information about the webkit-reviews mailing list