[webkit-reviews] review granted: [Bug 202061] SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame : [Attachment 379628] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 202061: SubFrameSOAuthorizationSession should ensure messages are posted in
the right order to the parent frame
https://bugs.webkit.org/show_bug.cgi?id=202061

Attachment 379628: Patch

https://bugs.webkit.org/attachment.cgi?id=379628&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 379628
  --> https://bugs.webkit.org/attachment.cgi?id=379628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379628&action=review

>
Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm
:-107
> -    if (!page || !navigationActionPtr)

We were doing a page check here and no longer now.
Might be safer to keep it.

> Source/WebKit/UIProcess/FrameLoadState.cpp:95
> +	   observersCopy.append(&observer);

We can use uncheckedAppend/resverInitialCapacity.
Or better, just use copyToVector if working or WTF::map(m_observers, [](auto&
observer) { return observer.get(); });