[webkit-reviews] review denied: [Bug 202177] [FTW] Correct compositing, shadow, and radial gradient implementations : [Attachment 379693] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 202177: [FTW] Correct compositing, shadow, and radial gradient
implementations
https://bugs.webkit.org/show_bug.cgi?id=202177

Attachment 379693: Patch

https://bugs.webkit.org/attachment.cgi?id=379693&action=review




--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 379693
  --> https://bugs.webkit.org/attachment.cgi?id=379693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379693&action=review

> Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:41
> +#include "FloatSize.h"

You don't need to include FloatSize.h because FloatRect.h includes it
indirectly.

> Source/WebCore/platform/graphics/win/Direct2DUtilities.cpp:97
> +    constexpr double dpiBase = 96.0;

96.0 → 96
https://webkit.org/code-style-guidelines/#float-suffixes

> Source/WebCore/platform/graphics/win/PathDirect2D.cpp:346
>  FloatRect Path::strokeBoundingRect(StrokeStyleApplier* applier) const

How will you implement Path::strokeBoundingRect which is taking
StrokeStyleApplier as the argument?

> Source/WebCore/platform/graphics/win/PlatformContextDirect2D.cpp:57
> +    RELEASE_ASSERT(SUCCEEDED(hr));

Let's use COMPtr method.

m_deviceContext.query(m_renderTarget.get());
RELEASE_ASSERT(!!m_deviceContext);

> Source/WebCore/platform/graphics/win/PlatformContextDirect2D.cpp:385
> +    compositeIfNeeded();

You don't need to call compositeIfNeeded here because endDraw is called above.