[webkit-reviews] review granted: [Bug 202297] Add some logging to help diagnose blank or stuck WKWebViews : [Attachment 379694] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 17:07:13 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 202297: Add some logging to help diagnose blank or stuck WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=202297

Attachment 379694: Patch

https://bugs.webkit.org/attachment.cgi?id=379694&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 379694
  --> https://bugs.webkit.org/attachment.cgi?id=379694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379694&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:379
> +    WTF::Optional<MonotonicTime>
_timeOfFirstVisibleContentRectUpdateWithPendingCommit;

Nit - I don’t think the WTF:: is necessary here.


More information about the webkit-reviews mailing list