[webkit-reviews] review granted: [Bug 137131] Web Inspector: tests under LayoutTests/inspector/debugger are flaky : [Attachment 379664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 15:59:47 PDT 2019

Joseph Pecoraro <joepeck at webkit.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 137131: Web Inspector: tests under LayoutTests/inspector/debugger are flaky

Attachment 379664: Patch


--- Comment #23 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 379664
  --> https://bugs.webkit.org/attachment.cgi?id=379664

View in context: https://bugs.webkit.org/attachment.cgi?id=379664&action=review

r=me, thanks for iterating!

> Source/JavaScriptCore/ChangeLog:30
> +	   (JSC::DebuggerPausePositions::sort): use type as secondary ordering
> +	   * debugger/DebuggerParseData.h: Rearranged type constants so that
Enter < Pause < Leave
> +	   this change along with sorting by type should guarantee that in case
of several pause

This might deserve a comment in code since it is not immediately apparent by
looking at the Enum that the order is required by comparisons later.

More information about the webkit-reviews mailing list