[webkit-reviews] review granted: [Bug 137131] Web Inspector: tests under LayoutTests/inspector/debugger are flaky : [Attachment 379664] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 137131: Web Inspector: tests under LayoutTests/inspector/debugger are flaky
https://bugs.webkit.org/show_bug.cgi?id=137131

Attachment 379664: Patch

https://bugs.webkit.org/attachment.cgi?id=379664&action=review




--- Comment #23 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 379664
  --> https://bugs.webkit.org/attachment.cgi?id=379664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379664&action=review

r=me, thanks for iterating!

> Source/JavaScriptCore/ChangeLog:30
> +	   (JSC::DebuggerPausePositions::sort): use type as secondary ordering
component.
> +	   * debugger/DebuggerParseData.h: Rearranged type constants so that
Enter < Pause < Leave
> +	   this change along with sorting by type should guarantee that in case
of several pause

This might deserve a comment in code since it is not immediately apparent by
looking at the Enum that the order is required by comparisons later.