[webkit-reviews] review granted: [Bug 202295] Bytecode cache should defer GC and hold API lock while encoding : [Attachment 379691] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 202295: Bytecode cache should defer GC and hold API lock while encoding
https://bugs.webkit.org/show_bug.cgi?id=202295

Attachment 379691: Patch

https://bugs.webkit.org/attachment.cgi?id=379691&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379691
  --> https://bugs.webkit.org/attachment.cgi?id=379691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379691&action=review

> Source/JavaScriptCore/ChangeLog:11
> +	   We already hold the API lock in
generateProgramBytecode/generateModuleBytecode, but we should also hold
> +	   the API lock in the larger scope of the public methods in JSScript.
Additionally, we should DeferGC as
> +	   part of generateProgramBytecode/generateModuleBytecode, to ensure
that the code generated is not collected
> +	   before being serialized.

is this definitely what's happening? Can we test it?