[webkit-reviews] review granted: [Bug 202279] [iOS] Lock screen controls can fail to play web content : [Attachment 379685] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 202279: [iOS] Lock screen controls can fail to play web content
https://bugs.webkit.org/show_bug.cgi?id=202279

Attachment 379685: Patch

https://bugs.webkit.org/attachment.cgi?id=379685&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 379685
  --> https://bugs.webkit.org/attachment.cgi?id=379685
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379685&action=review

r=me with changes. Also please fix build failures on EWS.

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:84
> +    invalidate();

Why not simply m_delegate.get().taskStateChangedCallback = nil; ? We don't
really need to lock and null out the client.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:318
> +    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(5 *
NSEC_PER_SEC)), dispatch_get_main_queue(), [assertion =
WTFMove(uiProcessAssertion)] { });

I seem to remember you need to explicitly call [assertion invalidate]; before
deallocating it.