[webkit-reviews] review granted: [Bug 202254] [iOS 13] Tapping on a non-editable text selection should toggle callout bar visibility instead of clearing selection : [Attachment 379645] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 202254: [iOS 13] Tapping on a non-editable text selection should toggle
callout bar visibility instead of clearing selection
https://bugs.webkit.org/show_bug.cgi?id=202254

Attachment 379645: Patch

https://bugs.webkit.org/attachment.cgi?id=379645&action=review




--- Comment #2 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 379645
  --> https://bugs.webkit.org/attachment.cgi?id=379645
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379645&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2191
> +

I’m guessing that the unobscuredArea check is for not doing a divide by zero,
but if there is no unobscured area, should we be toggling or clearing? Clearing
might make sense on this case as well?