[webkit-reviews] review granted: [Bug 202244] Add very basic PageCache support for RTCPeerConnection : [Attachment 379613] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202244: Add very basic PageCache support for RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=202244

Attachment 379613: Patch

https://bugs.webkit.org/attachment.cgi?id=379613&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 379613
  --> https://bugs.webkit.org/attachment.cgi?id=379613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379613&action=review

r=me

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:502
> +    // FIXME: We should do better here, it is way too easy to prevent
PageCache.
>  bool RTCPeerConnection::canSuspendForDocumentSuspension() const
>  {
>      return !hasPendingActivity();

I kinda think we should be able to remove this. Pending promised will be
resolved before any navigation. And events are OK to delay.