[webkit-reviews] review denied: [Bug 202041] [YARR] Properly handle surrogates when matching back references : [Attachment 379547] WIP - Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied  review:
Bug 202041: [YARR] Properly handle surrogates when matching back references
https://bugs.webkit.org/show_bug.cgi?id=202041

Attachment 379547: WIP - Patch

https://bugs.webkit.org/attachment.cgi?id=379547&action=review




--- Comment #7 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 379547
  --> https://bugs.webkit.org/attachment.cgi?id=379547
WIP - Patch

r-
This patch is mostly right.  It needs 2 changes.
1) We need to properly increment the patternIndex and index when matching
non-BMP characters.
2) There is a register clobbering issue on X86_64 since
tryReadUnicodeCharImpl() uses r10 as a temp and patternChar is also r10.

Posting a patch shortly that builds on this patch and addresses these two
issues.