[webkit-reviews] review granted: [Bug 202222] Don't fall back to default session if session can't be found for cookie operations : [Attachment 379573] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202222: Don't fall back to default session if session can't be found for
cookie operations
https://bugs.webkit.org/show_bug.cgi?id=202222

Attachment 379573: Patch

https://bugs.webkit.org/attachment.cgi?id=379573&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 379573
  --> https://bugs.webkit.org/attachment.cgi?id=379573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379573&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:-505
> -	   LOG_ERROR("Non-default storage session was requested, but there was
no session for it. Please file a bug unless you just disabled private browsing,
in which case it's an expected race.");

Should we leave behind this LOG_ERROR? Seems like a real error.